Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fluent/fluentd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.16.9
Choose a base ref
...
head repository: fluent/fluentd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.16.10
Choose a head ref
  • 9 commits
  • 11 files changed
  • 2 contributors

Commits on Sep 11, 2025

  1. v1.16: ci: update actions (#5091)

    **Which issue(s) this PR fixes**: 
    None.
    
    **What this PR does / why we need it**: 
    Update GitHub Actions to fix Windows Service tests failures.
    
        <internal:C:/hostedtoolcache/windows/Ruby/3.2.8/x64/lib/ruby/3.2.0/rubygems/core_extkernel_require.rb>:86:in
        `require': 127: The specified procedure could not be found. 
        - C:/hostedtoolcache/windows/Ruby/3.2.8/x64/lib/ruby/gems/3.2.0/gems/strptime-0.2.5/lib/strptime/strptime.so (LoadError)
    
    * ref: ruby/setup-msys2-gcc#26
    
    Note: It might be better to have it automatically updated by a bot, just
    like `master`.
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**: 
    CI fixes.
    
    Signed-off-by: Daijiro Fukuda <[email protected]>
    daipom authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    69f05a1 View commit details
    Browse the repository at this point in the history
  2. Backport(v1.16): README: remove Code Climate badge as the service has…

    … ended (#5035) (#5087)
    
    **Which issue(s) this PR fixes**:
    * Backport #5035
    * Fixes #5034
    
    **What this PR does / why we need it**:
    Remove the Code Climate badge as the service has ended. It appears that
    it hasn't been used recently, so just removing it would be sufficient
    for now.
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**:
    Not needed.
    
    Signed-off-by: Daijiro Fukuda <[email protected]>
    daipom authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    57d3738 View commit details
    Browse the repository at this point in the history
  3. Backport(v1.16): ci: remove reference to mock object after test (#5055)…

    … (#5086)
    
    **Which issue(s) this PR fixes**:
    * Backport #5055
    
    Fixes #5054
    
    **What this PR does / why we need it**:
    This PR will resolve CI error.
    
    **Docs Changes**:
    N/A
    
    **Release Note**:
    N/A
    
    ---------
    
    Signed-off-by: Shizuo Fujita <[email protected]>
    Signed-off-by: Daijiro Fukuda <[email protected]>
    Co-authored-by: Shizuo Fujita <[email protected]>
    daipom and Watson1978 authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    c301faa View commit details
    Browse the repository at this point in the history
  4. Backport(v1.16): server plugin helper: ensure to close all connection…

    …s at shutdown (#5026) (#5088)
    
    **Which issue(s) this PR fixes**:
    * Backport #5026
    
    **What this PR does / why we need it**:
    TCP server with `server` helper does not close all connections at
    shutdown process.
    When receiving data from multiple clients, the server receive the data
    continuously because the connection is not closed.
    
    The server will shut down properly by this PR
    
    ### Reproduce
    1. Launch Fluentd with following config file.
    2. Send syslog data from two or more clients using following client
    script
    3. Terminate Fluentd
    4. Relaunch Fluentd, then it shows the `2025-07-16 14:12:26 +0900
    [warn]: #0 restoring buffer file: path = xxxxxxxxx` in logs.
    
    * config
    
    ```
    <source>
      @type syslog
      tag system
    
      <transport tcp>
      </transport>
    
      bind 0.0.0.0
      port 5140
    </source>
    
    <match **>
      @type file
      path "#{File.expand_path('~/tmp/fluentd/maillog')}"
      <buffer>
        @type file
        path "#{File.expand_path('~/tmp/fluentd/buffer/buffer_syslog_maillog')}"
        flush_at_shutdown true
      </buffer>
    </match>
    ```
    
    * client script
    
    ```ruby
    require 'bundler/inline'
    gemfile do
      source 'https://rubygems.org'
      gem 'remote_syslog_sender'
    end
    
    def create_client
      Thread.new do
        sender = RemoteSyslogSender.new('127.0.0.1', 5140, protocol: :tcp)
        loop do
          sender.transmit("message body")
          sleep 0.5
        end
      end
    end
    
    clients = []
    3.times do
      clients << create_client
    end
    
    clients.each(&:join)
    ```
    
    Example code.
    ```
    @ary = [1,2,3]
    
    # It would like 1, 2, and 3 to be processed.
    # However, following code handles 1 and 3.
    @ary.each do |i|
      puts i
      @ary.delete(i)
    end
    ```
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**:
    Same as the title.
    
    Signed-off-by: Shizuo Fujita <[email protected]>
    Signed-off-by: Daijiro Fukuda <[email protected]>
    Co-authored-by: Shizuo Fujita <[email protected]>
    daipom and Watson1978 authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    cb90ad7 View commit details
    Browse the repository at this point in the history
  5. Backport(v1.16): test: ensure removing old engine on setup (#5057) (#…

    …5085)
    
    **Which issue(s) this PR fixes**:
    * Backport #5057
    
    Continued from
    
    * #5054
    * #5055 (6cac9f0)
    
    **What this PR does / why we need it**:
    Each test should not consider the initialization of `Fluent::Engine`. It
    should be the responsibility of `Fluent::Test.setup`.
    
    Note: Set `nil` explicitly to ensure that GC can remove the objects,
    though it is very strange that some objects can still exist after
    `remove_const` and `GC.start`.
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**:
    CI improvements.
    
    Signed-off-by: Daijiro Fukuda <[email protected]>
    daipom authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    2c17316 View commit details
    Browse the repository at this point in the history
  6. Backport(v1.16): ci: refactor out_forward compress setting test (#4896)…

    … (#5092)
    
    **Which issue(s) this PR fixes**: 
    * Partially backported from #4896
    
    **What this PR does / why we need it**: 
    Refactor out_forward compress setting tests.
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**: 
    CI fixes.
    
    Signed-off-by: Daijiro Fukuda <[email protected]>
    daipom authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    5c6ab69 View commit details
    Browse the repository at this point in the history
  7. Backport(v1.16): test_plugin_helper: fix test class name (#5064) (#5083)

    **Which issue(s) this PR fixes**:
    * Backport #5064
    
    **What this PR does / why we need it**:
    
    `test_config.rb` and `test_plugin_helper.rb` has same class name.
    
    
    https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8
    
    
    https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5
    
    The test class name should be unique.
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**:
    CI improvements.
    
    Signed-off-by: Shizuo Fujita <[email protected]>
    Signed-off-by: Daijiro Fukuda <[email protected]>
    Co-authored-by: Shizuo Fujita <[email protected]>
    daipom and Watson1978 authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    269a0e0 View commit details
    Browse the repository at this point in the history
  8. Backport(v1.16): ci: add "--report-slow-tests" option (#5063) (#5084)

    **Which issue(s) this PR fixes**:
    * Backport #5063
    
    **What this PR does / why we need it**:
    Very rarely, tests may take a long time to run, but it is difficult to
    determine which tests took a long time.
    
    At [test-unit](https://github.com/test-unit/test-unit) v3.6.3,
    `--report-slow-tests` option was introduced to show the top 5 slow
    tests.
    
    
    https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140
    
    I think it might be useful.
    
    Related to #5041
    
    **Docs Changes**:
    Not needed.
    
    **Release Note**:
    CI improvements.
    
    Signed-off-by: Shizuo Fujita <[email protected]>
    Signed-off-by: Daijiro Fukuda <[email protected]>
    Co-authored-by: Shizuo Fujita <[email protected]>
    daipom and Watson1978 authored Sep 11, 2025
    Configuration menu
    Copy the full SHA
    f98375c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2025

  1. v1.16.10

    Signed-off-by: Daijiro Fukuda <[email protected]>
    daipom authored Sep 12, 2025
    Configuration menu
    Copy the full SHA
    5114da6 View commit details
    Browse the repository at this point in the history
Loading