deb: improve process timing for safety and simplicity #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daipom
force-pushed
the
deb-improve-process-timing
branch
from
38e05e9 to
0b673de
Compare
kenhys
reviewed
Dec 11, 2024
kenhys
reviewed
Dec 11, 2024
daipom
force-pushed
the
deb-improve-process-timing
branch
from
0b673de to
9530ff2
Compare
Points * FROM-package just leaves tmp files if it supports the features. * TO-package trigger the features if there are those tmp files. * Thus, we don't need to check the version. * Make installing plugin and restarting the same condition. Before 1. from-prerm(upgrade): Do nothing. 2. to-preinst(upgrade): Collect plugin-list. Confirm version. 3. Install TO-package 4. from-postrm(upgrade): Do nothing. 5. Uninstall FROM-package 6. to-postinst(configure): Install plugin and restart if need. After 1. from-prerm(upgrade): * Check auto or not. * Leave plugin-list and pid if need. 2. to-preinst(upgrade): Set tmp files for TO-package. 3. Install TO-package 4. from-postrm(upgrade): Clean tmp files of FROM-package. 5. Uninstall FROM-package 6. to-postinst(configure): Install plugin and restart if need. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
deb-improve-process-timing
branch
from
9530ff2 to
be1f3fe
Compare
Contributor
Author
|
Thanks for your review! |
kenhys
pushed a commit
that referenced
this pull request
Dec 11, 2024
Points * FROM-package just leaves tmp files if it supports the features. * TO-package trigger the features if there are those tmp files. * Thus, we don't need to check the version. * Make installing plugin and restarting the same condition. Before 1. from-prerm(upgrade): Do nothing. 2. to-preinst(upgrade): Collect plugin-list. Confirm version. 3. Install TO-package 4. from-postrm(upgrade): Do nothing. 5. Uninstall FROM-package 6. to-postinst(configure): Install plugin and restart if need. After 1. from-prerm(upgrade): * Check auto or not. * Leave plugin-list and pid if need. 2. to-preinst(upgrade): Set tmp files for TO-package. 3. Install TO-package 4. from-postrm(upgrade): Clean tmp files of FROM-package. 5. Uninstall FROM-package 6. to-postinst(configure): Install plugin and restart if need. Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points
Before
After