Skip to content

Conversation

@Watson1978
Copy link
Contributor

Add missing prerm script to include it in debian package

@Watson1978 Watson1978 requested review from daipom and kenhys December 6, 2024 07:35
@daipom
Copy link
Contributor

daipom commented Dec 6, 2024

Thanks! But this should be merged to #713 because prerm is newly added there.

@Watson1978 Watson1978 changed the base branch from master to feature-nodowntime December 6, 2024 07:44
@Watson1978
Copy link
Contributor Author

Thanks. Fixed

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit d1d69f9 into fluent:feature-nodowntime Dec 9, 2024
143 checks passed
@Watson1978 Watson1978 deleted the include-prerm branch December 9, 2024 06:32
daipom pushed a commit to daipom/fluent-package-builder that referenced this pull request Dec 10, 2024
Add missing `prerm` script to include it in debian package

Signed-off-by: Shizuo Fujita <[email protected]>
daipom pushed a commit to daipom/fluent-package-builder that referenced this pull request Dec 10, 2024
Add missing `prerm` script to include it in debian package

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
kenhys pushed a commit that referenced this pull request Dec 11, 2024
Add missing `prerm` script to include it in debian package

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
@kenhys kenhys added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants