deb rpm: fix local dependency gem #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhys
force-pushed
the
fix-local-dependency-gem
branch
3 times, most recently
from
fda97f6 to
73a9d59
Compare
kenhys
changed the title
kenhys
force-pushed
the
fix-local-dependency-gem
branch
10 times, most recently
from
e3d2b34 to
930444b
Compare
Contributor
Author
|
service restart may need some more tweaks in rpm CI, but it is out of this PR. |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
930444b to
04d8157
Compare
Contributor
Author
|
TODO: add missing test case |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
5 times, most recently
from
2e71072 to
18bafd1
Compare
daipom
reviewed
Oct 22, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
18bafd1 to
5dfe5c2
Compare
daipom
reviewed
Oct 22, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
54e397f to
f264999
Compare
Contributor
Author
|
Fixed not matched local_missing_plugins. |
daipom
reviewed
Oct 31, 2024
fluent-package/templates/package-scripts/fluent-package/deb/postinst
Outdated
Show resolved
Hide resolved
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
d59be52 to
a04c249
Compare
daipom
reviewed
Oct 31, 2024
fluent-package/templates/package-scripts/fluent-package/deb/postinst
Outdated
Show resolved
Hide resolved
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
2f243d3 to
ba84806
Compare
daipom
reviewed
Oct 31, 2024
fluent-package/templates/package-scripts/fluent-package/deb/postinst
Outdated
Show resolved
Hide resolved
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
ba84806 to
d94cdb3
Compare
Contributor
Author
|
resolved conflict. |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
e6a4c01 to
4e11674
Compare
daipom
reviewed
Nov 1, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. Signed-off-by: Kentaro Hayashi <[email protected]>
When major upgrade process was executed, manually installed plugin/gem should be installed in advance. This PR test whether that mechanism will be launched. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
7bbf81d to
55dd93d
Compare
Contributor
Author
|
NOTE:
|
Contributor
|
(ボタン押し間違えました 🙇 ) |
kenhys
added a commit
that referenced
this pull request
Nov 5, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
that referenced
this pull request
Nov 19, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Nov 29, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 4, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 5, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 6, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 10, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
that referenced
this pull request
Dec 11, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
NOTE:
fail.
just to use fluent-gem detecting missing gems.