Skip to content

Fix logging to include exceptions in WorkflowExecutionService#786

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/issue-785
Dec 14, 2025
Merged

Fix logging to include exceptions in WorkflowExecutionService#786
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/issue-785

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

Summary

  • pass the caught exception into _logger.LogError across WorkflowExecutionService catch blocks so stack traces are preserved and logging matches other services
  • align the count helper methods to log the exception and message together, keeping error handling consistent with the rest of the persistence layer

Testing

  • dotnet test FlowSynx.sln (fails: local .NET SDK 9.0.307 cannot target net10.0; needs newer SDK to run suite)

Closes #785.

@mohin-io mohin-io requested review from a team as code owners December 13, 2025 23:01
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@ziagham ziagham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ziagham ziagham merged commit d315479 into flowsynx:master Dec 14, 2025
3 of 4 checks passed
@mohin-io
Copy link
Copy Markdown
Contributor Author

Thank you so much for the approval!@ziagham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Exception Not Passed to Logger in Catch Block in WorkflowExecutionService

2 participants