Skip to content

Fix structured logging in audit handlers (#724)#736

Merged
ziagham merged 3 commits intoflowsynx:masterfrom
mohin-io:issue-724-structured-logging
Nov 20, 2025
Merged

Fix structured logging in audit handlers (#724)#736
ziagham merged 3 commits intoflowsynx:masterfrom
mohin-io:issue-724-structured-logging

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Bug Fix

Description

  • ensure both audit handlers emit structured log messages so their telemetry always includes context
  • improve the exception logging in AuditsListHandler and keep the existing structured logging change in AuditDetailsHandler

Issue reference

Closes #724

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation / Created issue in flowsynx/website#
  • Specification has been updated / Created issue in flowsynx/website#
  • Provided sample for the feature / Created issue in flowsynx/website#

@mohin-io mohin-io requested review from a team as code owners November 19, 2025 23:51
Copy link
Copy Markdown
Contributor

@Sakeeb91 Sakeeb91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 736 only improves structured logging/doc for the audit handlers, and dotnet test FlowSynx.sln passes with just the usual pre-existing warnings. Nothing blocking merge from code or test results.

@sonarqubecloud
Copy link
Copy Markdown

@ziagham ziagham merged commit 8243187 into flowsynx:master Nov 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Exception is logged using ex.ToString() instead of structured exception logging

3 participants