Fix structured exception logging in LogsListHandler#728
Merged
ziagham merged 1 commit intoflowsynx:masterfrom Nov 17, 2025
Merged
Fix structured exception logging in LogsListHandler#728ziagham merged 1 commit intoflowsynx:masterfrom
ziagham merged 1 commit intoflowsynx:masterfrom
Conversation
|
Member
|
@djzh23 |
Contributor
Author
|
Thank you for merging the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR updates the exception logging in LogsListHandler to use structured logging instead of ex.ToString().
Structured logging keeps the exception metadata intact (stack trace, type, message), improves compatibility with logging providers, and follows .NET logging best practices.
Specifically:
Replaced _logger.LogError(ex.ToString());
with _logger.LogError(ex, "FlowSynx exception caught in LogsListHandler.");
No functional behavior was changed besides logging.
Issue reference
Closes #726
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: