Skip to content

Reduce WorkflowValidator.BuildGraph complexity#715

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-701-reduce-buildgraph-complexity
Nov 14, 2025
Merged

Reduce WorkflowValidator.BuildGraph complexity#715
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-701-reduce-buildgraph-complexity

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

Closes #701

Summary

  • Extracted a reusable edge helper so dependencies and conditional branches share identical adjacency logic, lowering BuildGraph cognitive complexity and future maintenance cost.
  • Added focused XML docstrings around the graph helpers to document intent and keep the validator aligned with the project's documentation-centric conventions.
  • Replaced the LINQ-based conditional branch enumeration with direct iteration for clarity while maintaining the existing workflow semantics.

Testing

  • dotnet test FlowSynx.sln (fails: installed SDK only supports up to .NET 8 while the solution targets .NET 9)

@mohin-io mohin-io requested review from a team as code owners November 13, 2025 22:24
@sonarqubecloud
Copy link
Copy Markdown

@ziagham ziagham merged commit 2786665 into flowsynx:master Nov 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Reduce Cognitive Complexity in BuildGraph Method

2 participants