Skip to content

Simplify eviction callback handling#705

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-703-merge-nested-if
Nov 12, 2025
Merged

Simplify eviction callback handling#705
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-703-merge-nested-if

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

Summary

  • merge the redundant nested eviction checks in PluginCacheService so unload only runs when the cache entry both expired or was removed and is a plugin loader, matching existing patterns in the infrastructure layer
  • add an XML summary on RegisterEvictionCallback to document why the callback exists and keep inline docs consistent with CONTRIBUTING guidance

Testing

  • dotnet test FlowSynx.sln (fails: installed SDK is 8.0.415 while the solution targets net9.0)

Fixes #703

@mohin-io mohin-io requested review from a team as code owners November 12, 2025 00:02
@sonarqubecloud
Copy link
Copy Markdown

@ziagham ziagham merged commit 3e1c345 into flowsynx:master Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Nested if statement should be merged for clarity and readability

2 participants