Skip to content

Fix/replace generic exceptions#689

Merged
ziagham merged 2 commits intoflowsynx:masterfrom
Icebice:fix/replace-generic-exceptions
Nov 9, 2025
Merged

Fix/replace generic exceptions#689
ziagham merged 2 commits intoflowsynx:masterfrom
Icebice:fix/replace-generic-exceptions

Conversation

@Icebice
Copy link
Copy Markdown
Contributor

@Icebice Icebice commented Nov 9, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Replaced Exception with ArgumentException. Added nameof() but removed them later because of SonarQube.

Issue reference

Closes #679

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ X] Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation / Created issue in flowsynx/website#
  • Specification has been updated / Created issue in flowsynx/website#
  • Provided sample for the feature / Created issue in flowsynx/website#

@Icebice Icebice requested review from a team as code owners November 9, 2025 19:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 9, 2025

Copy link
Copy Markdown
Member

@ziagham ziagham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, thank you for contribution!

@ziagham ziagham merged commit ee3d223 into flowsynx:master Nov 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid throwing System.Exception directly in user code

2 participants