Rename Version endpoint rate limit parameter#671
Merged
ziagham merged 1 commit intoflowsynx:masterfrom Nov 7, 2025
Merged
Conversation
|
ziagham
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Aligning the Map override signature with EndpointGroupBase is a solid improvement for consistency across the endpoint registration surface.
In particular, renaming rateLimitPolicy to rateLimitPolicyName makes the parameter’s intent much clearer and avoids the ambiguity around whether we’re passing a policy instance vs. a string key. This matches how the rest of the endpoint group extensions refer to rate-limiting configuration and helps reinforce the pattern for contributors working in this area.
The added XML documentation is also appreciated. It clarifies how the rate-limiting policy name flows from endpoint mapping through to the middleware pipeline, which was previously implicit and required reading internal code to understand. Having this documented in the public surface area reduces onboarding friction for future contributors and keeps the API self-describing.
As noted, there are no behavioral changes — just naming and documentation alignment — which keeps this low risk and improves consistency and maintainability.
I was unable to run dotnet build locally due to the repository currently targeting .NET 9.0 and my environment having only .NET SDK 8.0.415, but the changes here are isolated and do not appear to affect the underlying logic or runtime behavior.
Overall, this cleanup is a meaningful quality-of-life improvement for contributors working in the endpoint grouping layer.
Closes #607 👍