Skip to content

Align Plugins endpoint Map signature with base class#666

Merged
ziagham merged 2 commits intoflowsynx:masterfrom
mohin-io:fix/608-rename-rate-limit-policy-name
Nov 7, 2025
Merged

Align Plugins endpoint Map signature with base class#666
ziagham merged 2 commits intoflowsynx:masterfrom
mohin-io:fix/608-rename-rate-limit-policy-name

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

@mohin-io mohin-io commented Nov 6, 2025

Overview

  • Renamed the Map signature in Plugins to accept
    ateLimitPolicyName, mirroring the naming used in EndpointGroupBase.
  • Updated the single usage within the method so the rate limiting configuration continues to flow through unchanged.
  • Added a .lycheeignore entry for localhost development URLs so the automated link check no longer fails on intentionally local documentation examples.

Alignment with the Codebase

  • Keeps endpoint overrides consistent, following the same pattern used by other endpoint groups (for example Config, Logs, and Metrics).
  • Reduces future confusion when scanning overrides for discrepancies in parameter names.

Testing

  • dotnet test FlowSynx.sln (fails: local environment only has .NET SDK 8.0.415, while the solution targets .NET 9.0)

Fixes #608.

@mohin-io mohin-io requested review from a team as code owners November 6, 2025 16:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 6, 2025

@ziagham ziagham merged commit b255660 into flowsynx:master Nov 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename parameter rateLimitPolicy to rateLimitPolicyName in Plugins endpoint

2 participants