Skip to content

Fix workflows rate limit parameter naming consistency (#606)#665

Merged
ziagham merged 2 commits intoflowsynx:masterfrom
mohin-io:fix/606-rename-workflows-parameter
Nov 7, 2025
Merged

Fix workflows rate limit parameter naming consistency (#606)#665
ziagham merged 2 commits intoflowsynx:masterfrom
mohin-io:fix/606-rename-workflows-parameter

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

@mohin-io mohin-io commented Nov 6, 2025

Summary

  • Rename the Workflows.Map parameter to
    ateLimitPolicyName so it matches EndpointGroupBase
  • Update the rate-limiting call to use the renamed parameter
  • Document the local-only workflow endpoint examples and mark localhost URLs as local access only
  • Add .lycheeignore and update the link-check workflow to ignore localhost patterns used in our docs

Implementation Notes

  • Mirrors the documentation pattern already used by Config, Logs, and Metrics endpoint groups for consistency
  • Link checker exclusions ensure CI remains green without removing the helpful local examples from the README
  • No functional behavior changes were introduced beyond the naming alignment

Testing

  • dotnet build FlowSynx.sln (fails: local environment only has .NET SDK 8.0.415 while the solution targets .NET 9.0)

Closes #606

@mohin-io mohin-io requested review from a team as code owners November 6, 2025 16:25
@mohin-io mohin-io force-pushed the fix/606-rename-workflows-parameter branch from 717748d to 5750637 Compare November 6, 2025 18:06
@mohin-io mohin-io requested a review from a team as a code owner November 6, 2025 18:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 7, 2025

@ziagham ziagham merged commit ded079e into flowsynx:master Nov 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename parameter rateLimitPolicy to rateLimitPolicyName in Workflows endpoint

2 participants