Skip to content

fix: align Metrics Map signature with rate limit naming#618

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/rename-metrics-ratelimit-parameter-609
Oct 31, 2025
Merged

fix: align Metrics Map signature with rate limit naming#618
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/rename-metrics-ratelimit-parameter-609

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

@mohin-io mohin-io commented Oct 31, 2025

Summary

  • rename Metrics.Map parameter to
    ateLimitPolicyName to match EndpointGroupBase
  • ensure the metrics endpoint group applies rate limiting using the renamed parameter
  • add XML documentation that clarifies the rate-limiting parameter for the metrics endpoints

Testing

  • dotnet test (fails: dotnet CLI is not available in this environment)

Closes #609

@mohin-io mohin-io requested review from a team as code owners October 31, 2025 22:23
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ziagham ziagham merged commit 8d59ad5 into flowsynx:master Oct 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziagham ziagham ziagham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename parameter rateLimitPolicy to rateLimitPolicyName in Metrics endpoint

2 participants

@mohin-io @ziagham