Skip to content

Refactor: align Logs rate limit parameter name#614

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/rename-logs-ratelimit-parameter-610
Oct 31, 2025
Merged

Refactor: align Logs rate limit parameter name#614
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:fix/rename-logs-ratelimit-parameter-610

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

Summary

  • Rename the Map override parameter to
    ateLimitPolicyName so it matches the signature defined on EndpointGroupBase.
  • Update the internal usage to reference the renamed parameter when attaching the rate-limiting policy.
  • Document the override to clarify how the logs endpoints apply the named policy, mirroring existing project conventions for endpoint helpers.

Implementation Notes

  • The change keeps behaviour identical while ensuring override consistency; no other files consume the parameter by name, so only the local signature and call site required updates.
  • Added XML documentation to make the intent of the override explicit, aligning with the project guidance on descriptive comments for public endpoints.

Testing

  • dotnet test FlowSynx.sln (not run: .NET SDK is unavailable in the current environment)

Closes #610.

@mohin-io mohin-io requested review from a team as code owners October 30, 2025 23:13
@sonarqubecloud
Copy link
Copy Markdown

@ziagham ziagham merged commit eea70cb into flowsynx:master Oct 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename parameter rateLimitPolicy to rateLimitPolicyName in Logs endpoint

2 participants