Reduce LogTemplate.Format cognitive complexity (#592)#604
Merged
ziagham merged 1 commit intoflowsynx:masterfrom Oct 29, 2025
Merged
Conversation
|
Sakeeb91
approved these changes
Oct 29, 2025
Contributor
Sakeeb91
left a comment
There was a problem hiding this comment.
LGTM. I spot-checked the refactor in src/FlowSynx.Infrastructure/Logging/LogTemplate.cs and confirmed the helper extraction keeps the original behavior. dotnet build src/FlowSynx.Infrastructure/FlowSynx.Infrastructure.csproj still passes. Only lingering risk is that malformed-token scenarios remain untested, same as before. Merge when ready.
ziagham
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
LogTemplate.Formatinto focused helpers to cut the cognitive complexity below the 15 point threshold described in Refactor Method to Reduce Cognitive Complexity #592Implementation Details
HandleOpeningBrace,HandleClosingBrace,AppendCharacter, andGetValueForTermto encapsulate the responsibilities previously mixed insideFormatCONTRIBUTING.mdregarding maintainable, well-documented codeFlowSynxExceptionwhen an unknown token is encountered, ensuring compatibility with existing telemetry and alertsTesting
dotnet test(blocked:dotnetCLI is not available in the current CLI environment)Closes #592.