Skip to content

refactor: remove ITransactionService and TransactionService#556

Merged
ziagham merged 2 commits intoflowsynx:masterfrom
arch92:fix/534-transaction-service
Oct 22, 2025
Merged

refactor: remove ITransactionService and TransactionService#556
ziagham merged 2 commits intoflowsynx:masterfrom
arch92:fix/534-transaction-service

Conversation

@arch92
Copy link
Copy Markdown
Contributor

@arch92 arch92 commented Oct 22, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Removed ITransactionService and TransactionService files.

    • FlowSynx.Domain/ITransactionService.cs
    • FlowSynx.Persistence.Postgres/Services/TransactionService.cs
  • Removed references, usings, and Dependency Injections related to TransactionService

Issue reference

Closes #534

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation / Created issue in flowsynx/website#
  • Specification has been updated / Created issue in flowsynx/website#
  • Provided sample for the feature / Created issue in flowsynx/website#

@arch92 arch92 requested a review from a team as a code owner October 22, 2025 06:07
@ziagham ziagham requested review from Sakeeb91 and removed request for a team October 22, 2025 07:01
.AddScoped<IWorkflowTaskExecutionService, WorkflowTaskExecutionService>()
.AddScoped<IWorkflowTriggerService, WorkflowTriggerService>()
.AddScoped<ITransactionService, TransactionService>()
.AddScoped<IWorkflowTriggerService, WorkflowTriggerService>()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/FlowSynx.Persistence.Postgres/Extensions/ServiceCollectionExtensions.cs:37 – new trailing whitespace after WorkflowTriggerService; please trim to avoid formatting drift.

@arch92 arch92 requested a review from a team as a code owner October 22, 2025 14:12
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@Sakeeb91 Sakeeb91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@ziagham ziagham merged commit 8275429 into flowsynx:master Oct 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ITransactionService and TransactionService from the codebase

3 participants