Skip to content

Remove unused workflow trigger dependencies (#544, #545)#546

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-544-545
Oct 20, 2025
Merged

Remove unused workflow trigger dependencies (#544, #545)#546
ziagham merged 1 commit intoflowsynx:masterfrom
mohin-io:issue-544-545

Conversation

@mohin-io
Copy link
Copy Markdown
Contributor

@mohin-io mohin-io commented Oct 20, 2025

Summary

What & Why

  • Removed the unused system clock dependency from the workflow triggers list handler so it only relies on the services it actually calls.
  • Cleaned the associated using directives so the handler matches the rest of the application layering conventions.
  • Dropped the unused service provider field from the result storage factory and kept the existing guard clauses focused on the remaining dependencies to reduce confusion for new contributors.

Design Decisions

  • Left the existing logging and pagination flow untouched to stay consistent with the surrounding handlers.
  • Reordered the factory constructor assignments to keep null-checks and configuration logic aligned with the pattern used across infrastructure services.

Testing

  • .dotnet/dotnet build FlowSynx.sln --configuration Release
  • .dotnet/dotnet test FlowSynx.sln --configuration Release --no-build

Alignment

  • Changes follow the repository's guard-clause pattern and reuse the existing localization and pagination utilities without introducing new abstractions.
  • No new tests were required because existing unit coverage already exercises the affected entry points.

@mohin-io mohin-io requested a review from a team as a code owner October 20, 2025 19:53
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@ziagham ziagham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cahnges.

@ziagham ziagham merged commit b0f57e5 into flowsynx:master Oct 20, 2025
4 checks passed
@mohin-io
Copy link
Copy Markdown
Contributor Author

Thanks for appreciating @ziagham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants