Skip to content

Refactor repeated GUID validation into shared extension#537

Merged
ziagham merged 1 commit intoflowsynx:masterfrom
Sakeeb91:issue-536-guid-validation
Oct 20, 2025
Merged

Refactor repeated GUID validation into shared extension#537
ziagham merged 1 commit intoflowsynx:masterfrom
Sakeeb91:issue-536-guid-validation

Conversation

@Sakeeb91
Copy link
Copy Markdown
Contributor

@Sakeeb91 Sakeeb91 commented Oct 20, 2025

Summary

  • add a reusable MustBeValidGuid FluentValidation extension under FlowSynx.Application.Extensions
  • refactor every validator that previously duplicated BeAValidGuid to call the shared helper while keeping localized messages
  • add focused unit tests that cover valid/invalid GUID paths and argument guards

Testing

  • dotnet test FlowSynx.sln

Fixes #536

@Sakeeb91 Sakeeb91 requested a review from a team as a code owner October 20, 2025 13:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Sakeeb91
Copy link
Copy Markdown
Contributor Author

Sakeeb91 commented Oct 20, 2025

lychee link checker failing when hitting http://discord.flowsynx.io even after a rerun. We need to either mute or update the external link @ziagham

@ziagham
Copy link
Copy Markdown
Member

ziagham commented Oct 20, 2025

lychee link checker failing when hitting http://discord.flowsynx.io even after a rerun. We need to either mute or update the external link @ziagham

It will be fixed.

@ziagham
Copy link
Copy Markdown
Member

ziagham commented Oct 20, 2025

@Sakeeb91 FYI:
the broken link was fixed and lychee was passed.

ziagham
ziagham approved these changes Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ziagham ziagham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! The build completed successfully, and all tests passed.

@ziagham ziagham merged commit 4b47944 into flowsynx:master Oct 20, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziagham ziagham ziagham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor repeated GUID validation into a reusable FluentValidation extension

2 participants

@Sakeeb91 @ziagham