-
Notifications
You must be signed in to change notification settings - Fork 26
Mark PluginTypeParser class as static #775
Copy link
Copy link
Labels
C#C# related codeC# related codeMaintainabilitybugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring code
Description
What version of FlowSynx?
1.2.5
Describe the bug
File: src/FlowSynx.Application/PluginHost/Parser/PluginTypeParser.cs
The class only contains static members (or is intended to operate as a utility/parser class). However, it does not define a private constructor and is not declared as static.
This allows unintended instantiation of the class and violates best practices for utility classes.
The class PluginTypeParser is currently declared as:
public sealed class PluginTypeParser
{
// ...
}Proposed Fix
Mark the class as static:
public static class PluginTypeParser
{
// static methods...
}Benefits
- Prevents misuse by blocking class instantiation
- Communicates intent clearly (utility/static class)
- Aligns with clean-code and API design conventions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C#C# related codeC# related codeMaintainabilitybugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring code