-
Notifications
You must be signed in to change notification settings - Fork 26
Remove unused method parameter requestBody in ExecuteWorkflowAsync #704
Copy link
Copy link
Labels
C#C# related codeC# related codeMaintainabilitybugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
What version of FlowSynx?
1.2.3
Describe the bug
File: src/FlowSynx.Infrastructure/Workflow/Triggers/HttpBased/WorkflowHttpTriggerProcessor.cs
Method: ExecuteWorkflowAsync
The method ExecuteWorkflowAsync currently has an unused parameter requestBody.
private async Task ExecuteWorkflowAsync(
WorkflowTriggerEntity trigger,
string? requestBody,
CancellationToken cancellationToken)
{
// method implementation
}Since requestBody is not used anywhere in the method, it should be removed to clean up the code and avoid compiler warnings.
Also, note where ExecuteWorkflowAsync is called at line 61; it should be updated as follows:
_workflowHttpListener.RegisterRoute(trigger.UserId, method, route, async (request) =>
{
await ExecuteWorkflowAsync(trigger, request.Body, cancellationToken);
});Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C#C# related codeC# related codeMaintainabilitybugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed