-
Notifications
You must be signed in to change notification settings - Fork 26
Rename parameter rateLimitPolicy to rateLimitPolicyName in Logs endpoint #610
Copy link
Copy link
Closed
Labels
C#C# related codeC# related codebugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability
Description
What version of FlowSynx?
1.2.2
Describe the bug
In the Logs class, the Map method currently defines the parameter as rateLimitPolicy, while the base class (EndpointGroupBase) uses rateLimitPolicyName.
To maintain consistency and avoid potential confusion or mismatched overrides, the parameter should be renamed to match the base class definition.
File: src/FlowSynx/Endpoints/Logs.cs
Method: Map
Proposed change
public override void Map(WebApplication app, string rateLimitPolicyName)Rationale
- Ensures consistency with the base class method signature.
- Improves code readability and prevents potential confusion when overriding methods.
- Aligns with standard naming conventions in the codebase.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C#C# related codeC# related codebugSomething isn't workingSomething isn't workingcode cleanupcleaning-up codecleaning-up codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability