-
Notifications
You must be signed in to change notification settings - Fork 26
Make 'ExtractZipFromBytesAsync' a static method. #552
Copy link
Copy link
Labels
C#C# related codeC# related codeenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfest-acceptedhelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability
Description
What version of FlowSynx?
1.2.1
Describe the bug
The method ExtractZipFromBytesAsync is currently an instance method:
File: src/FlowSynx.Infrastructure/PluginHost/Manager/PluginDownloader.cs line 135
private async Task ExtractZipFromBytesAsync(Since this method does not depend on any instance state and only operates on its input parameter, it should be made static.
Proposed Change:
private static async Task ExtractZipFromBytesAsync(This change will:
- Clarify that
ExtractZipFromBytesAsyncdoes not rely on instance state. - Potentially improve performance slightly by avoiding the need for an instance reference.
- Make it easier to call from other static contexts if you need to.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C#C# related codeC# related codeenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfest-acceptedhelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability