-
Notifications
You must be signed in to change notification settings - Fork 26
Make ComputeChecksum a static method #550
Copy link
Copy link
Closed
Labels
C#C# related codeC# related codebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershacktoberfest-acceptedhelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability
Description
What version of FlowSynx?
1.2.1
Describe the bug
The method ComputeChecksum is currently an instance method:
File: src/FlowSynx.Infrastructure/PluginHost/Manager/PluginDownloader.cs line 105
private string ComputeChecksum(byte[] data)Since this method does not depend on any instance state and only operates on its input parameter, it should be made static.
Proposed Change:
private static string ComputeChecksum(byte[] data)This change will:
- Clarify that ComputeChecksum does not rely on instance state.
- Potentially improve performance slightly by avoiding the need for an instance reference.
- Make it easier to call from other static contexts if you need to.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C#C# related codeC# related codebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershacktoberfest-acceptedhelp wantedExtra attention is neededExtra attention is neededrefactoringRefactoring codeRefactoring codereliability