Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flowsynx/flowctl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.1
Choose a base ref
...
head repository: flowsynx/flowctl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.2
Choose a head ref
  • 9 commits
  • 26 files changed
  • 2 contributors

Commits on Nov 20, 2025

  1. Configuration menu
    Copy the full SHA
    18cc272 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44433b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8ee042e View commit details
    Browse the repository at this point in the history
  4. Remove merge note file

    Sakeeb91 committed Nov 20, 2025
    Configuration menu
    Copy the full SHA
    c2fc3a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    320e66c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2025

  1. Configuration menu
    Copy the full SHA
    b02453f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #133 from Sakeeb91/feature/docker-engine

    Add Docker init and runtime support for engine
    ziagham authored Nov 27, 2025
    Configuration menu
    Copy the full SHA
    41093a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2025

  1. Add Docker support for FlowSynx engine and resolve conflicts

    This commit introduces Docker support for the FlowSynx engine,
    including an implementation plan and necessary abstractions. Key
    changes include:
    
    - Added `IDockerService` abstraction for Docker operations.
    - Introduced `flowctl init --docker` and `flowctl run --docker`
      commands for initializing and running the engine in Docker mode.
    - Persisted deployment mode and Docker metadata in `appsettings.json`.
    - Defaulted to a host bind mount (`~/.flowsynx/data -> /app/data`)
      for data persistence, with options for overrides.
    - Addressed risks like Docker unavailability, port conflicts, and
      permission issues with clear error handling and guidance.
    
    Additionally, resolved a merge conflict in `RunCommandOptionsHandler.cs`
    between `feature/docker-engine` and `master` by integrating Docker
    logic with upstream documentation and formatting improvements.
    Tests were re-run to ensure correctness.
    
    #134
    ziagham committed Nov 29, 2025
    Configuration menu
    Copy the full SHA
    3ae51b3 View commit details
    Browse the repository at this point in the history
  2. Add support for additional Docker arguments

    Introduced the `AdditionalArguments` property in `DockerRunOptions` to allow specifying extra Docker command arguments.
    
    Added the `GetDockerModeAsync` method to `IDockerService` and implemented it in `DockerService` to dynamically determine the Docker operating system type (Linux, Windows, or Unknown) using the `docker info` command.
    
    Updated `RunContainerAsync` in `DockerService` to include `AdditionalArguments` in Docker commands.
    
    Refactored `InitCommandOptionsHandler` to use `GetDockerModeAsync` for platform detection and set `AdditionalArguments` to `" --start"` when creating Docker containers.
    
    Removed an extraneous closing brace in `InitCommand`.
    
    These changes improve platform-awareness and enhance flexibility in Docker command execution.
    
    #135
    ziagham committed Nov 29, 2025
    Configuration menu
    Copy the full SHA
    bf2e7b8 View commit details
    Browse the repository at this point in the history
Loading