@haiphucnguyen I have addressed all the comments, however I am having some issues with filtering by the Priority. While I figure that out and unit tests (hopefully by tomorrow) you can add your reviews for the rest of the code.

@haiphucnguyen I have addressed all the comments, however I am having some issues with filtering by the Priority. While I figure that out and unit tests (hopefully by tomorrow) you can add your reviews for the rest of the code.

Sure @MrChatterjee98 . Yeah, i also just commented to ask you write some tests :). Looking forward to your update

@haiphucnguyen Please check out the final changes from my end with added tests

Hi @MrChatterjee98 , I am going to create a PR to demonstrate a new reporting api and add you as a reviewer. You please let me know how that approach work, then see if you can apply to this PR. Please keep me some days :)

Gladly 😀

Gladly 😀

Hi @MrChatterjee98,

I created a follow-up PR (#287
) based on your work. It’s not fully complete yet—specifically, the tests for TicketAgingReportControllerIT and TicketAgingReportServiceIT are still in progress.

The original requirements around buckets turned out to be quite complex, so I simplified the approach and adjusted the implementation accordingly. The changes are largely aligned with your PR.

I plan to continue working on this tomorrow. If you’re okay with it, I can close my PR afterward and you can continue working on your original PR, or we can go with whichever approach you prefer.

Thanks again for the solid work!

@haiphucnguyen

I took a look at your PR and I would be happy to implement those changes and update my current PR. However, I have some observations.

1. I noticed that the filtered tickets age is calculated

   flowinquiry/apps/backend/commons/src/main/java/io/flowinquiry/modules/teams/service/TicketAgingReportService.java

   Line 38 in 4ed82b1

   List<TicketAgingDTO> agingTickets =

   they are only sorted based on age but not grouping is done i.e., the buckets are not present, is it a part of the simplifications of the requirements?
2. I also noticed that we do not have any provision to calculate already closed tickets, Although I think you're trusting me to implement that as a part of my PR 😄.
   

   flowinquiry/apps/backend/commons/src/main/java/io/flowinquiry/modules/teams/service/TicketAgingReportService.java

   Line 133 in 4ed82b1

   long ageInDays = ChronoUnit.DAYS.between(ticket.getCreatedAt(), Instant.now());

if you think my observations are correct, I will go forward and make the changes to my PR and update it as

@haiphucnguyen

I took a look at your PR and I would be happy to implement those changes and update my current PR. However, I have some observations.

1. I noticed that the filtered tickets age is calculated

   flowinquiry/apps/backend/commons/src/main/java/io/flowinquiry/modules/teams/service/TicketAgingReportService.java

   Line 38 in 4ed82b1

   List<TicketAgingDTO> agingTickets =

   
   they are only sorted based on age but not grouping is done i.e., the buckets are not present, is it a part of the simplifications of the requirements?
2. I also noticed that we do not have any provision to calculate already closed tickets, Although I think you're trusting me to implement that as a part of my PR 😄.
   

   flowinquiry/apps/backend/commons/src/main/java/io/flowinquiry/modules/teams/service/TicketAgingReportService.java

   Line 133 in 4ed82b1

   long ageInDays = ChronoUnit.DAYS.between(ticket.getCreatedAt(), Instant.now());

if you think my observations are correct, I will go forward and make the changes to my PR and update it as

You're absolutely right @MrChatterjee98 😀 That’s the foundation for the PR, so feel free to add anything that’s missing. I realize I made the requirements too complicated at the start, sorry about that. The bucketing logic is very complex, and most of the time users don’t really need it. If they do, we’ll provide a custom solution for each customer instead of a generic one for everyone.

@haiphucnguyen I have updated the PR code according to the PR you provided, and I will be updating the tests soon. Merry Christmas 😃

Edit 1: I have added new unit tests. Please take a look

P.S: Aging is American English while Ageing is British English I was following the latter for naming my services and functions (as I am used to it), however I have reverted it to Aging everywhere in case I have missed please let me know via the comments in PR.

Most of these functions/classes are named during the first draft, I'll update them and let you know

Most of these functions/classes are named during the first draft, I'll update them and let you know

Thanks @MrChatterjee98

@haiphucnguyen Please take a look I have changed the names, also for some reason the CI pipelines failed can't figure out why? For my forked repo I re-ran them, and they seem to be working link

@haiphucnguyen Please take a look I have changed the names, also for some reason the CI pipelines failed can't figure out why? For my forked repo I re-ran them, and they seem to be working link

No worries, @MrChatterjee98. I re‑ran the workflows and they all passed. It looks like a GitHub intermittent build issue.

If you’d like to jump in, feel free to pick any open issue #274, which covers both front‑end and back‑end work. You’re welcome to open a brand‑new issue and build it from scratch. Your contributions would be a huge help to the project!