feat: refactor sending email flow#278
Merged
haiphucnguyen merged 1 commit intoflowinquiry:mainfrom Oct 27, 2025
Merged
Conversation
|
|
caominhduc52
force-pushed
the
feature/seek-based-pagination-refactor
branch
from
b369812 to
fffcb8f
Compare
Contributor
Author
|
Hi a @haiphucnguyen kindly help me to review this PR and grant CI permission to run 
|
haiphucnguyen
approved these changes
Oct 27, 2025
Collaborator
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Thanks @caominhduc52 for your contribution. LGTM
| LIMIT :size | ||
| """ | ||
| ) | ||
| List<Ticket> findOverdueTicketsAfterId(@Param("id") Long id, @Param("size") int size); |
Collaborator
There was a problem hiding this comment.
This sparked an idea for a follow-up improvement: the current query (and the previous one) isn't optimized for performance due to missing indexes. I've created a follow-up ticket to add the necessary indexes. Do you want to take a look? 😊
Collaborator
Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor SendEmailForTicketOverdue to use seek based pagination approach
#253
Changes Made
Additional Notes