feat: FL-187 adding close button#276
Merged
haiphucnguyen merged 1 commit intoflowinquiry:mainfrom Oct 24, 2025
Merged
Conversation
Contributor
Author
|
@haiphucnguyen please checkout this PR |
Collaborator
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Hi @MrChatterjee98 , the PR looks good to me, thank you.
Just have a minor comment for coding improvement
| let result: ProjectIterationDTO; | ||
| result = await closeProjectIteration(iteration?.id!); | ||
| onOpenChange(false); | ||
| if (onSave) { |
Collaborator
There was a problem hiding this comment.
can you change attributes:
onSave
onCancel
of the type ProjectIterationDialogProps is mandantory then we don't need to have a check
if (onSave) . I checked the logic from project view, we don't need to keep these method onSave, or onCancel as optional.
Note in the PR: just in case if we have an optional field onSave, instead of writing this code
if (onSave) {
onSave(result);
}
with typescript, we can write the cleaner code
onSave?.(result)
Contributor
Author
There was a problem hiding this comment.
I have made the necessary changes
Collaborator
|
Thank you @MrChatterjee98 for the first PR on front-end side :) |
haiphucnguyen
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a close button to the iteration dialog box, which is enabled only for active iterations and can be used to close the current iteration.
Changes Made
Additional Notes