Add a new email job table and email service to schedule sending emails#263
Merged
haiphucnguyen merged 3 commits intoflowinquiry:mainfrom Feb 25, 2026
Merged
Conversation
|
|
haiphucnguyen
requested changes
Sep 29, 2025
Collaborator
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
@larry-ca thank you for your PR. I left some comments, also we need to write some tests to validate the json, yaml format processing in our code.
...ckend/commons/src/main/java/io/flowinquiry/modules/collab/service/job/SendRelayEmailJob.java
Outdated
Show resolved
Hide resolved
...ckend/commons/src/main/java/io/flowinquiry/modules/collab/service/job/SendRelayEmailJob.java
Show resolved
Hide resolved
...commons/src/main/java/io/flowinquiry/modules/collab/service/MailTemplateRendererService.java
Show resolved
Hide resolved
- Add EMAIL_JOB_BATCH_LIMIT constant to unify batch size and simplify configuration. - Extract template context preparation into its own method for better readability and reuse. - Extend MailTemplateRendererService with documentation detailing the required YAML‑markdown template structure. - Update SendRelayEmailJob to use the new constant and helper, improving maintainability.
Contributor
Author
|
Hi @haiphucnguyen , could you review this PR again. Thanks |
haiphucnguyen
approved these changes
Feb 25, 2026
Collaborator
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Thanks @larry-ca for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fw_email_joband send emailsI will do the follow up task to convert the existing sending email task to persist the email records to fw_email_job table, and let schedule job to send emails.