FL-187 adding close iteration controller#258
Conversation
haiphucnguyen
changed the title
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @MrChatterjee98. I’ve added some comments - mostly small improvements. Keep it up!
apps/backend/server/src/main/resources/config/application-dev.yml
Outdated
Show resolved
Hide resolved
...ackend/server/src/test/java/io/flowinquiry/modules/teams/controller/ProjectControllerIT.java
Outdated
Show resolved
Hide resolved
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/ProjectIterationService.java
Outdated
Show resolved
Hide resolved
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/ProjectIterationService.java
Outdated
Show resolved
Hide resolved
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/ProjectIterationService.java
Outdated
Show resolved
Hide resolved
...mmons/src/main/java/io/flowinquiry/modules/teams/domain/ProjectIterationStatusConverter.java
Outdated
Show resolved
Hide resolved
...ommons/src/main/java/io/flowinquiry/modules/teams/service/mapper/ProjectIterationMapper.java
Outdated
Show resolved
Hide resolved
...ackend/commons/src/main/java/io/flowinquiry/modules/teams/domain/ProjectIterationStatus.java
Outdated
Show resolved
Hide resolved
MrChatterjee98
force-pushed
the
main
branch
from
76d8a00 to
de8fb6b
Compare
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Thanks @MrChatterjee98 ! I just add a minor comments. Others look good to me.
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/ProjectIterationService.java
Outdated
Show resolved
Hide resolved
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/ProjectIterationService.java
Outdated
Show resolved
Hide resolved
|
I am looking into it, Will commit the new changes by tomorrow. |
MrChatterjee98
force-pushed
the
main
branch
from
de8fb6b to
0ff2c98
Compare
|
I have done the changes as per your request, please take a look |
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Hi @MrChatterjee98 I have two improvements recommendation. Others than that, it is good
apps/backend/commons/src/main/java/io/flowinquiry/modules/teams/service/TicketService.java
Outdated
Show resolved
Hide resolved
...ommons/src/main/java/io/flowinquiry/modules/teams/repository/ProjectIterationRepository.java
Outdated
Show resolved
Hide resolved
MrChatterjee98
force-pushed
the
main
branch
from
0ff2c98 to
7b67e40
Compare
haiphucnguyen
left a comment
haiphucnguyen
left a comment
There was a problem hiding this comment.
Thanks @MrChatterjee98 for quickly push a new PR. Just a very small comment to remove a redundant package then we are good to go.
...kend/commons/src/main/java/io/flowinquiry/modules/teams/service/dto/ProjectIterationDTO.java
Outdated
Show resolved
Hide resolved
MrChatterjee98
force-pushed
the
main
branch
from
7b67e40 to
7c157a0
Compare
I have taken care of it, please have a look |
2 participants
Description
An endpoint for closing the current iteration which adds a new iteration by auto implementation
Changes Made
Additional Notes