Skip to content

Email watchers of Overdue ticket#246

Merged
haiphucnguyen merged 5 commits intoflowinquiry:mainfrom
anurrags:email-ticket-watchers
Jul 27, 2025
Merged

Email watchers of Overdue ticket#246
haiphucnguyen merged 5 commits intoflowinquiry:mainfrom
anurrags:email-ticket-watchers

Conversation

@anurrags
Copy link
Copy Markdown
Contributor

@anurrags anurrags commented Jul 21, 2025 •
edited
Loading

Description

This fixes: #161. Created a cron job which runs at 00:00 everday and fetch all the overdue tickets and send email notifications to all the watchers of the ticket.

Changes Made

  • New method in TicketRepository to fetch all overdue tickets.
  • New method in TicketService to use the method in TicketRepository to fetch all overdue tickets in Pageable form.
  • New cron service to send an email to the watchers of all overdue tickets
  • Added a method in UserService to getUser by Id. This is required as WatcherEntityService only gives the watcher userId.
  • created a new email template for overdue tickets

@anurrags anurrags mentioned this pull request Jul 21, 2025
Closed
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@anurrags anurrags force-pushed the email-ticket-watchers branch from e320d1d to 66f44ed Compare July 21, 2025 15:04
haiphucnguyen
haiphucnguyen reviewed Jul 22, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haiphucnguyen haiphucnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @anurrags - great job overall! The implementation looks solid. One recommendation: for critical flows like sending notifications, it's safer to use seek pagination instead of offset pagination to avoid duplicates or missed records if new data is inserted during processing. I also comments some minor stuffs but it is not a blocker for this PR.

@anurrags
Copy link
Copy Markdown
Contributor Author

anurrags commented Jul 27, 2025

Hi @haiphucnguyen
Can you please merge this PR and create new issues with the improvements you mentioned in the above comments.

@haiphucnguyen haiphucnguyen mentioned this pull request Jul 27, 2025
Closed
@haiphucnguyen
Copy link
Copy Markdown
Collaborator

haiphucnguyen commented Jul 27, 2025

Hi @haiphucnguyen Can you please merge this PR and create new issues with the improvements you mentioned in the above comments.

Great work, @anurrags! 🎉 I've created a follow-up ticket for your reference: #253.
Looking forward to seeing more of your awesome contributions. Thanks again for your help! 🙌

@haiphucnguyen haiphucnguyen merged commit be3da52 into flowinquiry:main Jul 27, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haiphucnguyen haiphucnguyen haiphucnguyen approved these changes

+1 more reviewer

@ArkaBando ArkaBando ArkaBando left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send email to ticket watchers if the project ticket is overdue

4 participants

@anurrags @CLAassistant @haiphucnguyen @ArkaBando