Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

Removed

  • Removed async processing
  • DataFrame::pipeline method

Deprecated

Security


Description

Closes: #793 - more details about reasons behind that change in issue description.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.266mb -1.55%  | 362.037ms -30.84% | ±0.73% +862.24% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.924mb -7.01%   | 263.697ms -34.80% | ±0.15% -93.20%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.032mb -5.59%   | 582.189ms -29.67% | ±0.26% -70.52%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.729mb -0.12% | 746.828ms -33.76% | ±0.61% +99.24%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.858mb -5.88%   | 19.072ms -28.13%  | ±2.27% +89.20%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.858mb -5.88%   | 406.329ms -37.31% | ±0.73% -59.17%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.118mb -0.32% | 48.149ms -38.72% | ±0.56% -51.84% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.306mb -0.36%  | 567.438ms -30.47% | ±2.72% +100.82% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.138mb -0.75%  | 69.138ms -14.78%  | ±0.40% -80.30%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.583mb -0.31%  | 62.606ms -30.28%  | ±1.03% -4.70%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 292.425mb -0.10% | 1.528s -38.26%    | ±0.75% +73.89%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.632mb -1.69%  | 40.747ms -4.77%   | ±0.14% -83.12%  |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.717mb -0.46% | 2.219ms -56.16%   | ±0.51% -84.06%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.509mb -0.43% | 149.397ms -28.50% | ±0.52% +347.00%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 59.035mb -0.59% | 14.968ms -29.34%  | ±3.20% +373.31%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.856mb -0.47% | 1.782ms -49.64%   | ±0.19% -93.39%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.856mb -0.47% | 1.799ms -49.41%   | ±0.28% -89.24%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.069mb -0.48% | 2.641ms -43.75%   | ±2.02% +34.16%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.598mb -0.47% | 14.237ms -46.09%  | ±1.20% +27.44%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.597mb -0.47% | 14.237ms -45.02%  | ±0.49% +25.29%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.669mb -0.49% | 1.794μs -31.16%   | ±2.67% +49.06%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.669mb -0.49% | 0.400μs -20.00%   | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.902mb -0.43% | 10.185ms -37.20%  | ±1.32% +74.64%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.422mb -0.31% | 47.702ms -34.20%  | ±1.27% +11.97%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.119mb -0.47% | 1.955ms -47.80%   | ±0.79% -75.53%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.388mb -0.56% | 33.052ms -40.23%  | ±1.50% -11.01%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.219mb -0.45% | 4.860ms -46.71%   | ±0.81% -29.36%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.669mb -0.49% | 37.165ms -39.81%  | ±1.65% +60.65%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.669mb -0.49% | 37.669ms -39.49%  | ±1.04% -20.89%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.669mb -0.49% | 37.804ms -39.21%  | ±1.43% +1434.12% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.943mb -0.47% | 7.199ms -36.15%   | ±0.27% -72.13%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.668mb -0.49% | 29.165ms -35.64%  | ±1.60% +119.41%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.669mb -0.49% | 12.700μs -50.15%  | ±0.64% +31.62%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.669mb -0.49% | 15.288μs -51.93%  | ±1.70% +1048.43% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.510mb -0.43% | 154.257ms -27.71% | ±0.45% -58.98%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 93.714mb -0.36% | 123.620ms -32.15% | ±1.61% +476.25%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 48.642mb -0.71% | 63.348ms -32.47%  | ±2.34% +232.74%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.658mb -2.74% | 15.026ms -35.89%  | ±1.85% -19.69%   |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@norberttech norberttech merged commit 1b0a7f5 into flow-php:1.x Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove AsyncPipeline

1 participant