Skip to content

feat: add no-header flag to csv export#841

Merged
andrinoff merged 3 commits intofloatpane:masterfrom
A-R-Narke:add-csv-header-flag-707
Apr 22, 2026
Merged

feat: add no-header flag to csv export#841
andrinoff merged 3 commits intofloatpane:masterfrom
A-R-Narke:add-csv-header-flag-707

Conversation

@A-R-Narke
Copy link
Copy Markdown
Contributor

@A-R-Narke A-R-Narke commented Apr 21, 2026

What?

Added flag -no-header for suppressing header row in csv
Added tests for it and updated docs

Why?

Closes #707

@A-R-Narke A-R-Narke requested a review from a team as a code owner April 21, 2026 23:26
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A-R-Narke! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (74 characters). The PR title must be strictly under 40 characters.

@github-actions github-actions Bot added documentation Documentation changes enhancement New feature or request labels Apr 21, 2026
@A-R-Narke A-R-Narke changed the title FEAT: Add option to suppress header row in CSV contacts export Closes #707 feat(cli):add option to suppress header row in CSV contacts export #707 Apr 21, 2026
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A-R-Narke! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (71 characters). The PR title must be strictly under 40 characters.

@A-R-Narke A-R-Narke requested a review from floatpanebot April 21, 2026 23:32
@A-R-Narke A-R-Narke changed the title feat(cli):add option to suppress header row in CSV contacts export #707 feat(cli): add no-header flag #707 Apr 21, 2026
@floatpanebot floatpanebot dismissed stale reviews from themself April 21, 2026 23:35

Formatting issues have been resolved. Thank you!

@andrinoff
Copy link
Copy Markdown
Member

@A-R-Narke Why? section should include the wording Fixes/Closes #<issue-number>, or the description of an issue, if the issue was not previously created.

@github-actions github-actions Bot added the bug Something isn't working label Apr 22, 2026
@andrinoff andrinoff changed the title feat(cli): add no-header flag #707 feat: add no-header flag to contact export Apr 22, 2026
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrinoff! Please fix the following issues with your PR:

  • Title: Is too long (42 characters). The PR title must be strictly under 40 characters.

@andrinoff andrinoff changed the title feat: add no-header flag to contact export feat: add no-header flag to csv export Apr 22, 2026
@floatpanebot floatpanebot dismissed their stale review April 22, 2026 06:48

Formatting issues have been resolved. Thank you!

Copy link
Copy Markdown
Member

@andrinoff andrinoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-R-Narke, Resolve the pending comments.

Good PR, just some small things to correct.

Comment thread cli/contacts_export_test.go Outdated
Comment thread cli/contacts_export_test.go Outdated
Comment thread cli/contacts_export.go
@andrinoff andrinoff removed the bug Something isn't working label Apr 22, 2026
@A-R-Narke A-R-Narke requested a review from andrinoff April 22, 2026 10:43
@andrinoff
Copy link
Copy Markdown
Member

/approve

Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@andrinoff andrinoff merged commit dda7a7c into floatpane:master Apr 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation changes enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Add option to suppress header row in CSV contacts export

3 participants