fix(fetcher): decode bad charset#1214
Merged
andrinoff merged 1 commit intofloatpane:masterfrom May 2, 2026
Merged
Conversation
floatpanebot
previously requested changes
May 2, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @guyua9! Please fix the following issues with your PR:
- Title: Is too long (54 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
guyua9
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Member
|
/approve |
floatpanebot
approved these changes
May 2, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
decodePartso malformedContent-Typeheaders still go through the charset decoder instead of returning raw bytes.Content-Typewith ISO-8859-1 bytes and malformedContent-Typewithout a charset.Fixes #1085.
Why?
Malformed
Content-Typeheaders can still include a usable charset. Returning raw bytes in that path makes non-UTF-8 email bodies render as mojibake. Decoding with the best-effort charset keeps those messages readable while preserving UTF-8 fallback behavior.Tests
/Users/ming/.cache/go-toolchains/go1.26.2/bin/go test ./fetcher/Users/ming/.cache/go-toolchains/go1.26.2/bin/go vet ./fetcher/Users/ming/.cache/go-toolchains/go1.26.2/bin/go test ./fetcher ./config ./backend ./backend/jmap ./cli ./daemon ./daemonclient ./daemonrpc ./internal/httpclient ./pluginNote:
go test ./...was attempted locally, but this environment could not complete unrelated packages because of aproxy.golang.orgEOF while downloadinggithub.com/arran4/golang-icaland a local macOS CommandLineTools cgo architecture error.