Skip to content

fix(daemon): notify only when new mail#1205

Merged
andrinoff merged 2 commits intofloatpane:masterfrom
EmilyxFox:fix/notify-when-no-new-mail
Apr 30, 2026
Merged

fix(daemon): notify only when new mail#1205
andrinoff merged 2 commits intofloatpane:masterfrom
EmilyxFox:fix/notify-when-no-new-mail

Conversation

@EmilyxFox
Copy link
Copy Markdown
Contributor

What?

Fixes notifications every 5 minutes whether or not there are new emails

Why?

Discussed in Discord

@EmilyxFox EmilyxFox requested a review from a team as a code owner April 30, 2026 15:02
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EmilyxFox! Please fix the following issues with your PR:

  • Title: Is too long (77 characters). The PR title must be strictly under 40 characters.

@github-actions github-actions Bot added the bug Something isn't working label Apr 30, 2026
@EmilyxFox EmilyxFox changed the title fix(daemon): only show syncAllAccounts notification when there are new emails only show syncAllAccounts notify on new emails Apr 30, 2026
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EmilyxFox! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (46 characters). The PR title must be strictly under 40 characters.

@EmilyxFox EmilyxFox changed the title only show syncAllAccounts notify on new emails fix(daemon): notify only when new mail Apr 30, 2026
@floatpanebot floatpanebot dismissed stale reviews from themself April 30, 2026 15:04

Formatting issues have been resolved. Thank you!

Comment thread daemon/daemon.go Outdated
Copy link
Copy Markdown
Member

@andrinoff andrinoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrinoff
Copy link
Copy Markdown
Member

/approve

Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@andrinoff andrinoff merged commit ee3b6d7 into floatpane:master Apr 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants