Skip to content

chore: use strings.Builder#1016

Merged
andrinoff merged 1 commit intofloatpane:masterfrom
mavonx:fix/issue-966
Apr 26, 2026
Merged

chore: use strings.Builder#1016
andrinoff merged 1 commit intofloatpane:masterfrom
mavonx:fix/issue-966

Conversation

@mavonx
Copy link
Copy Markdown
Contributor

@mavonx mavonx commented Apr 25, 2026

What?

Replaced repeated string concatenation in tui/email_view.go with strings.Builder.

Why?

To reduce allocations and improve rendering performance in frequently updated UI paths.

Changes

  • Converted shortcuts building to strings.Builder
  • Converted cryptoStatus building to strings.Builder

Closes #966

@mavonx mavonx requested a review from a team as a code owner April 25, 2026 20:48
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Haroka-74! Please fix the following issues with your PR:

  • Title: Is too long (58 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@github-actions github-actions Bot added the chore Maintenance, refactor, cleanup label Apr 25, 2026
@mavonx mavonx changed the title refactor(tui): use strings.Builder in email view rendering refactor(tui): use strings.Builder Apr 25, 2026
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Haroka-74! Please fix the following issues with your PR:

  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@floatpanebot floatpanebot dismissed their stale review April 25, 2026 20:51

Formatting issues have been resolved. Thank you!

@github-actions github-actions Bot added the performance Performance improvement label Apr 25, 2026
@floatpanebot floatpanebot dismissed their stale review April 25, 2026 20:51

Formatting issues have been resolved. Thank you!

@mavonx mavonx requested a review from floatpanebot April 25, 2026 20:51
@andrinoff andrinoff changed the title refactor(tui): use strings.Builder chore: use strings.Builder Apr 25, 2026
@mavonx mavonx changed the title chore: use strings.Builder refactor(tui): use strings.Builder Apr 25, 2026
@mavonx mavonx changed the title refactor(tui): use strings.Builder chore: use strings.Builder Apr 25, 2026
Copy link
Copy Markdown
Member

@andrinoff andrinoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrinoff andrinoff merged commit 6ce2588 into floatpane:master Apr 26, 2026
27 of 29 checks passed
@mavonx mavonx deleted the fix/issue-966 branch April 26, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, refactor, cleanup performance Performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: String concatenation with += for crypto status in email view

3 participants