Remove /src from .npmignore (for debugging) #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popper publishes source maps to NPM (great!) but it doesn't publish the /src folder that the sourcemaps point to. This makes it harder to debug into & set breakpoints in popper code from Chrome or an IDE like VSCode. This PR updates .npmignore to ensure that the /src folder is also, along with /dist, is published to NPM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popper publishes source maps to NPM (great!) but it doesn't publish the
/srcfolder that the sourcemaps point to. This makes it harder to debug into & set breakpoints in popper code from Chrome or an IDE like VSCode. This PR updates .npmignore to ensure that the/srcfolder is also (along with/dist) published to NPM.This shouldn't change anything about Popper's runtime user-facing behavior and the tests probably operate on the source (not a package downloaded from NPM), so I wasn't sure how to build a test to validate these changes. Let me know if you think that new tests are needed.
Fixes #785.