fix(useFloating): avoid setting isPositioned to true when open is false
#3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0186e50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vibrant-gates-22c214 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lozinsky
changed the title
isPositioned to true when open is false
lozinsky
commented
Sep 11, 2024
lozinsky
force-pushed
the
fix/vue-is-positioned
branch
from
2d0b417 to
0186e50
Compare
Collaborator
|
Does this close the whole issue, or was my comment and subsequent PR only a somewhat related bug? |
Contributor
Author
|
This should close #3017 and also sync vue behaviour with react behaviour. Your PR is about the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3017
Sync with #3042