Merged
Conversation
goosewobbler
added
the
WIP
goosewobbler
added
WIP
goosewobbler
added
WIP
goosewobbler
removed
the
WIP
mholtzman
reviewed
May 3, 2023
goosewobbler
added
the
WIP
goosewobbler
removed
the
WIP
mholtzman
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows EN-US 101 key layout the right Alt key (AltGr on UK keyboards) works the same as the left Alt key. For EN-GB and all other layouts it registers as
Control + Alt.We can fix the above behaviour on non-US key layouts; when either the
AltorAltGrmodifier is used:Control + Alt + {shortcutKey}should be registered, which will ensure that the right alt key worksAlt + {shortcutKey}should be registered, which will ensure that the left alt key also worksThis is also an issue on Linux, the solution there is to register the (undocumented) accelerator
AltRight(instead ofControl + Altabove)The KeyboardLayoutMap can be used to determine if the EN-US layout is being used, as it is the only layout where
Backslashmaps to\.https://www.w3.org/TR/uievents-code/#keyboard-101
Related Electron issue: electron/electron#13895