Skip to content

Fix parcel buffer install when building prod#1517

Merged
goosewobbler merged 1 commit intodevelopfrom
fix-parcel-buffer
Apr 13, 2023
Merged

Fix parcel buffer install when building prod#1517
goosewobbler merged 1 commit intodevelopfrom
fix-parcel-buffer

Conversation

@goosewobbler
Copy link
Contributor

@goosewobbler goosewobbler commented Apr 11, 2023

Parcel is still complaining about buffer not being installed when building prod even though we removed it from the renderer builds. I think this is related to the below issue:

parcel-bundler/parcel#7697

I checked all dependency usage of buffer via npm ls buffer and all of the imports for deps which have a dependency on buffer are in the main process. However, setting the alias to "buffer" instead of false does fix the issue without breaking the build.

@mholtzman
Copy link
Collaborator

@goosewobbler it seems like parcel has some sort of trigger where it sees that process is defined and determines that this is a node process and thus wants to install buffer. do we have any idea why that's happening or if there's a way to fix that root cause?

otherwise I think this is a fine workaround for the time being

@goosewobbler
Copy link
Contributor Author

I'm not sure that is what's happening, let alone why - how did you verify that? I tried removing all references to process in the renderer and that did nothing.

@mholtzman
Copy link
Collaborator

I'm not sure that is what's happening, let alone why - how did you verify that? I tried removing all references to process in the renderer and that did nothing.

didnt verify it just saw it mentioned in a few places, thought it might be good to understand why this is happening, but either way I think going w. this fix is fine for now.

@goosewobbler goosewobbler merged commit a4d75fe into develop Apr 13, 2023
@goosewobbler goosewobbler deleted the fix-parcel-buffer branch April 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants