Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Powered by socket.dev

@SocketSecurity ignore [email protected] [email protected]

@goosewobbler looks good to me. one thing I noticed when running and attempting to add a Lattice signer is this message:

(node:403101) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time

are they using the experimental Fetch API and, if so, are we OK w that?

@mholtzman Fetch is now opt-out, globally available since N18 but still "experimental".

https://nodejs.org/en/blog/announcements/v18-release-announce/#new-globally-available-browser-compatible-apis

See the SDK docs for their usage, seems they use native fetch if available and we have to explicitly patch it with node-fetch.
https://github.com/GridPlus/gridplus-sdk/blob/dev/docs/docs/intro.md

@mholtzman Fetch is now opt-out, globally available since N18 but still "experimental".

https://nodejs.org/en/blog/announcements/v18-release-announce/#new-globally-available-browser-compatible-apis

See the SDK docs for their usage, seems they use native fetch if available and we have to explicitly patch it with node-fetch. https://github.com/GridPlus/gridplus-sdk/blob/dev/docs/docs/intro.md

OK I think this is fine, just want to do a quick double check and make a note of it in case we see anything weird coming from its usage in any other parts of the app