Conversation
1 task
mholtzman
reviewed
Mar 7, 2023
main/store/migrations/index.js
Outdated
| // ensure chain exists in networksMeta | ||
| initial.main.networksMeta.ethereum[id] = initial.main.networksMeta.ethereum[id] || {} | ||
|
|
||
| const { nativeCurrency } = initial.main.networksMeta.ethereum[id] |
Collaborator
There was a problem hiding this comment.
I don't think this is quite right, it still throws an exception below when trying to reference an undefined nativeCurrency. I'm updating and adding a couple tests
Contributor
Author
There was a problem hiding this comment.
ok, could probably do with a test for the case where a chain has no networksMeta value too
Collaborator
There was a problem hiding this comment.
yep, there's one in there
goosewobbler
commented
Mar 7, 2023
Contributor
Author
goosewobbler
left a comment
goosewobbler
left a comment
There was a problem hiding this comment.
Approved @mholtzman's changes
mholtzman
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.