Conversation
mholtzman
changed the title
mholtzman
force-pushed
the
make-signers-ts
branch
from
aa1c144 to
4e9bc09
Compare
goosewobbler
reviewed
Mar 6, 2023
goosewobbler
reviewed
Mar 6, 2023
goosewobbler
reviewed
Mar 6, 2023
mholtzman
force-pushed
the
make-signers-ts
branch
from
8df50dc to
7ff6126
Compare
mholtzman
force-pushed
the
make-signers-ts
branch
from
21bcf1e to
76cb96b
Compare
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
Contributor
|
@SocketSecurity ignore [email protected] |
goosewobbler
approved these changes
Mar 17, 2023
mholtzman
force-pushed
the
make-signers-ts
branch
from
e6b47d6 to
338c978
Compare
Contributor
|
We should consider #1526 as part of this. |
mholtzman
force-pushed
the
make-signers-ts
branch
from
2d98a5e to
415b266
Compare
* bump version * remove infura and alchemy presets, use pylon * update package lock * remove gnosis chain preset * fix chain name
* add Zod validation of state chain objects, infer types * move state files to TS, add more inferred types * fix persist mock for tests * add types to main state * update test * add mute notification schema * move type export to state main * move legacy file to TS * try new migration format * update legacy migrations and tests * fix gas fees type * fix gas type * move legacy mapping * final migration prototype * finish migration poc * finish cleaning up migrations * test cleanup * fix compilation error * fix state parsing
Co-authored-by: goosewobbler <[email protected]> Co-authored-by: goosewobbler <[email protected]>
mholtzman
force-pushed
the
make-signers-ts
branch
from
415b266 to
883e6d7
Compare
mholtzman
added a commit
that referenced
this pull request
Jun 23, 2023
* Integrate pylon evm (#1478) * bump version * remove infura and alchemy presets, use pylon * update package lock * remove gnosis chain preset * fix chain name * move migrations to separate files, use TS (#1482) * add Zod validation of state chain objects, infer types (#1485) * add Zod validation of state chain objects, infer types * move state files to TS, add more inferred types * fix persist mock for tests * add types to main state * update test * add mute notification schema * move type export to state main * move legacy file to TS * try new migration format * update legacy migrations and tests * fix gas fees type * fix gas type * move legacy mapping * final migration prototype * finish migration poc * finish cleaning up migrations * test cleanup * fix compilation error * fix state parsing * Choose summon keybinding (#1494) Co-authored-by: goosewobbler <[email protected]> Co-authored-by: goosewobbler <[email protected]> * re-order migrations * convert hot signers to TS, make tests run reliably * more commits * update comment * remove unneeded assignment * make worker interaction more typesafe * remove unused code * remove unused interface * fix tests * revert weird test change * try revert file * try move * decouple worker controller and launch script, write controller tests * fix worker exit in tests * remove double cast * rename some files * remove ignore * clean up worker interface * last cleanup, fix typed data * more type safety * rebase, add bip39 type * remove ts-ignores * remove rebase artifact * remove migration files * update package lock --------- Co-authored-by: goosewobbler <[email protected]> Co-authored-by: goosewobbler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to refactor the signers into TS without changing the tests to give some assurance that nothing is broken, then will follow on with another PR updating the tests.