fix(build): order release preparation tasks#6219
Merged
Merged
Conversation
Signed-off-by: Mark Phelps <[email protected]>
dosubot
Bot
added
the
size:XS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Fixes a real race condition in the release prep task by ensuring clean completes before ui:build runs. Looks correct — no changes requested.
🤖 Automated review by the Flipt PR review agent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #6219 +/- ##
=======================================
Coverage 62.27% 62.27%
=======================================
Files 145 145
Lines 14815 14815
=======================================
Hits 9226 9226
Misses 4829 4829
Partials 760 760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
cleanfrom deleting UI assets after the Vite build during release preparation.cleanbeforeui:buildinmise run prepui/embed.goassetsValidation
mise tasks validatemise run prepgo build -tags=assets ./cmd/fliptmise run testis blocked locally by the inheritedcommit.gpgSignconfiguration in Git fixture tests.