fix(ui): lazy init useState in MetadataForm and CopyToNamespacePanel#6171
Merged
Conversation
avoid re-evaluating initializers like objectToMetadataArray on every render. Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:XS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Clean, focused fix that correctly switches two useState calls to lazy initialization so their initializers run only on mount rather than every render. No issues.
🤖 Automated review by the Flipt PR review agent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #6171 +/- ##
=======================================
Coverage 62.27% 62.27%
=======================================
Files 145 145
Lines 14750 14750
=======================================
Hits 9186 9186
Misses 4816 4816
Partials 748 748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
markphelps
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid re-evaluating initializers like objectToMetadataArray on every render.