fix(redis): route go-redis internal logs through zap#6132
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Clean, focused change that routes go-redis internal logs through zap as intended. The adapter correctly implements the go-redis logging interface, the tests verify the core behavior, and separating the global side effect from NewStore is a good design choice. No issues found.
🤖 Automated review by the Flipt PR review agent.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #6132 +/- ##
=======================================
Coverage 62.26% 62.27%
=======================================
Files 143 144 +1
Lines 14733 14738 +5
=======================================
+ Hits 9174 9178 +4
- Misses 4813 4814 +1
Partials 746 746
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
erka
force-pushed
the
rd/v2/redis
branch
2 times, most recently
from
July 5, 2026 13:00
b97f9e5 to
6494b63
Compare
erka
marked this pull request as ready for review
July 5, 2026 13:18
dosubot
Bot
added
the
size:S
go-redis v9 writes connection pool and dial errors to os.Stderr via Go's standard log package with a "redis: " prefix. Replace the global logger with a zap adapter so these logs follow the same structured formatting as the rest of the application. Signed-off-by: Roman Dmytrenko <[email protected]>
markphelps
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-redis v9 writes connection pool and dial errors to os.Stderr via
Go's standard log package with a "redis: " prefix. Replace the global
logger with a zap adapter so these logs follow the same structured
formatting as the rest of the application.