fix(streaming): deprecate name and description in evaluation snapshot#5990
Conversation
|
The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: approve
Clean, focused change that safely removes internal flag and segment metadata from evaluation snapshots while preserving backward compatibility through proto field deprecation. No issues found.
🤖 Automated review by the Flipt PR review agent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5990 +/- ##
==========================================
- Coverage 61.41% 61.40% -0.02%
==========================================
Files 142 142
Lines 14265 14261 -4
==========================================
- Hits 8761 8757 -4
Misses 4770 4770
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f04b3bb to
c303a46
Compare
dosubot
Bot
added
the
size:M
There was a problem hiding this comment.
Verdict: comment
The PR cleanly removes deprecated name and description fields from evaluation snapshots, but the new buf format --write --exit-code line in the go:fmt task will fail after formatting proto files due to the --exit-code flag interacting with set -e.
.mise.toml
- minor (L217):
buf format --write --exit-codeexits with code 1 after it rewrites files. Because the script usesset -euo pipefail, thego:fmttask will report failure the first time a developer runs it after modifying an unformatted proto file, even though the formatter succeeded. This is inconsistent withgolangci-lint fmt(which exits 0 after writing) and creates a confusing local dev experience. Remove--exit-codefrom the formatting command, or move proto formatting to a separateproto:fmttask.
🤖 Automated review by the Flipt PR review agent.
c303a46 to
fca3779
Compare
There was a problem hiding this comment.
Verdict: comment
The snapshot changes are clean and backward-compatible. The only remaining issue is the addition of buf format --write --exit-code in the go:fmt task, which will cause the task to fail when it actually rewrites proto files due to set -e.
.mise.toml
- minor (L216): The new
buf format --write --exit-codecommand exits with code 1 when it rewrites a file. Because the script usesset -euo pipefail, thego:fmttask will fail the first time a developer runs it after modifying an unformatted proto file, even though the formatter succeeded. This is inconsistent withgolangci-lint fmt(which exits 0 after writing) and creates a confusing local dev experience. Remove--exit-codefrom the formatting command.
🤖 Automated review by the Flipt PR review agent.
Stop populating name and description fields on EvaluationFlag and EvaluationSegment in evaluation snapshot responses. These fields are marked deprecated in the protobuf schema and are no longer set by the snapshot builder, reducing the surface of internal information exposed to evaluation clients. Backward compatible: deprecated fields remain in the wire format but will always be empty strings. Signed-off-by: Roman Dmytrenko <[email protected]>
fca3779 to
eaa323e
Compare
There was a problem hiding this comment.
Verdict: approve
Looks good — no changes requested.
🤖 Automated review by the Flipt PR review agent.
2 participants
Stop populating name and description fields on EvaluationFlag and EvaluationSegment in evaluation snapshot responses. These fields are marked deprecated in the protobuf schema and are no longer set by the
snapshot builder, reducing the surface of internal information exposed to evaluation clients.
Backward compatible: deprecated fields remain in the wire format but will always be empty strings.
closes: #5989