docs: correct typos in error type and authentication config comments#5937
Merged
Conversation
Signed-off-by: immanuwell <[email protected]>
dosubot
Bot
added
the
size:S
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Straightforward typo-only fixes in godoc and struct field comments — no functional changes, no issues.
🤖 Automated review by the Flipt PR review agent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5937 +/- ##
=======================================
Coverage 61.28% 61.28%
=======================================
Files 141 141
Lines 14208 14208
=======================================
Hits 8707 8707
Misses 4772 4772
Partials 729 729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors/errors.go:convience->convenience(7 occurrences across allErr*fvar comments), andIt us up to->It is up toinErrNotModifiedinternal/config/authentication.go:provention->preventionin the CSRF field commentChanges
errors/errors.go: fix spelling and grammar in godoc commentsinternal/config/authentication.go: fix spelling in struct field commentBackward Compatibility
Comment-only changes, zero functional impact.
Additional Notes
Spotted while reading through the errors package. The
conviencetypo was copy-pasted across all 7 error factory var comments, so fixing them all in one shot.