chore: upgrade dagger to v0.21.0#5926
Merged
Merged
Conversation
- dagger upgrade: engine v0.20.3 → v0.21.0, SDK v0.20.3 → v0.20.7-rc - fix nil directory return in Integration command — returns dag.Directory() instead of nil, nil to prevent `Error: printID: unexpected type for object: nil` - adds UNIQUE env var for azure lowkey-vault to prevent container caching collisions on rerun Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:M
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Looks good — upgrades dagger engine and SDK, fixes nil directory return, and improves Azure vault integration. Only minor suggestion: add inline rationale for the new UNIQUE env var injection.
build/testing/integration.go
- minor (L1007): Environment variable
UNIQUEis now injected for the Azure Lowkey Vault container setup, using uuid.NewString(). While this prevents container caching collisions, consider clarifying its documentation or rationale, as future maintainers may not know why it is needed. Add an inline code comment explaining the purpose ofUNIQUEand its impact on container behavior.
🤖 Automated review by the Flipt PR review agent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5926 +/- ##
=======================================
Coverage 61.29% 61.29%
=======================================
Files 141 141
Lines 14211 14211
=======================================
Hits 8710 8710
Misses 4772 4772
Partials 729 729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to prevent
Error: printID: unexpected type for object: nil