Skip to content

Allow camel cases in flag keys in the UI#5917

Merged
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
keshane:patch-1
May 27, 2026
Merged

Allow camel cases in flag keys in the UI#5917
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
keshane:patch-1

Conversation

@keshane

@keshane keshane commented May 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #5916

@keshane
keshane requested a review from a team as a code owner May 26, 2026 22:49
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @keshane! Thanks for your contribution to this project.

It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license.

How to fix this:

# For future commits, use the -s flag
git commit -s -m "Your commit message"

# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-lease

The -s flag adds this line to your commit message:
Signed-off-by: Your Name <[email protected]>

📋 View the failing DCO check for more details

For more information about the DCO, visit: https://developercertificate.org/

keshane and others added 2 commits May 26, 2026 15:51
Signed-off-by: Keshane Gan <[email protected]>
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.29%. Comparing base (95b8f4d) to head (6600409).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #5917   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         141      141           
  Lines       14211    14211           
=======================================
  Hits         8710     8710           
  Misses       4772     4772           
  Partials      729      729           
Flag Coverage Δ
integrationtests 34.51% <ø> (ø)
unittests 52.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka added the v2 Flipt v2 label May 27, 2026
@erka erka added the automerge Used by Kodiak bot to automerge PRs label May 27, 2026

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @keshane!

@kodiakhq
kodiakhq Bot merged commit 527a520 into flipt-io:v2 May 27, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:XS This PR changes 0-9 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Flag keys are automatically lowercased in the UI but shouldn't be

2 participants